Improve op amp convergence for differentiator circuits#254
Open
esaruoho wants to merge 1 commit intopfalstad:v3-devfrom
Open
Improve op amp convergence for differentiator circuits#254esaruoho wants to merge 1 commit intopfalstad:v3-devfrom
esaruoho wants to merge 1 commit intopfalstad:v3-devfrom
Conversation
Two changes to OpAmpElm.doStep(): 1. Add voltage limiting: clamp the differential input voltage change between iterations to prevent Newton-Raphson overshoot. With gain=100000, the linear region is only ~0.3mV wide, so large voltage steps cause the iteration to bounce between saturation states indefinitely. 2. Replace random getrand(4) escape mechanism with a deterministic subIterations-based check. The random 25% chance of switching saturation direction introduced nondeterministic behavior that destabilized otherwise-converging iterations in high-gain circuits like differentiators with fast transient inputs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpAmpElm.doStep():getrand(4)==1check with a deterministicsubIterations > 20condition. The random 25% chance of switching saturation direction introduced nondeterministic oscillation that destabilized converging iterations in high-gain circuits.Test plan
Fixes #82
🤖 Generated with Claude Code