zend call stack fixing stack limit for macOs arm64.#13319
Closed
devnexen wants to merge 1 commit intophp:masterfrom
Closed
zend call stack fixing stack limit for macOs arm64.#13319devnexen wants to merge 1 commit intophp:masterfrom
devnexen wants to merge 1 commit intophp:masterfrom
Conversation
arnaud-lb
reviewed
Feb 5, 2024
Member
arnaud-lb
left a comment
There was a problem hiding this comment.
Thank you! The code change looks good to me, but the new comments are redundant with the existing comment bellow them.
We could make the change self-explanatory by merging the code paths. For example (in pseudo code) :
if (pthread_main_np() && !arm64) {
/* existing comment explaining the workaround for older OSX versions */
max_size = 8 * 1024 * 1024;
} else {
max_size = pthread_get_stacksize_np(pthread_self());
}
04cd85a to
8165853
Compare
Contributor
should be slightly faster on modern macos edit: fixed a logic error |
8MB sounded a prudent size for older 10.9 macOs release, however with newer mac with arm64, it triggers a stack overflow.
8165853 to
7f770c1
Compare
Contributor
|
LGTM 👍 |
arnaud-lb
approved these changes
Feb 5, 2024
arnaud-lb
pushed a commit
to arnaud-lb/php-src
that referenced
this pull request
Aug 6, 2025
8MB sounded a prudent size for older 10.9 macOs release, however with newer mac with arm64, it triggers a stack overflow. close phpGH-13319
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8MB sounded a prudent size for older 10.9 macOs release, however with newer mac with arm64, it triggers a stack overflow.