metrics: set sync load latency as P9999#56981
metrics: set sync load latency as P9999#56981ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56981 +/- ##
=================================================
- Coverage 73.2941% 56.2922% -17.0019%
=================================================
Files 1638 1764 +126
Lines 453785 632687 +178902
=================================================
+ Hits 332598 356154 +23556
- Misses 100814 252495 +151681
- Partials 20373 24038 +3665
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, lance6716, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
/cherrypick release-8.1 |
|
@hawkingrei: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@hawkingrei: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #56980
Problem Summary:
What changed and how does it work?
The current sync load monitoring primarily focuses on P95 latency, which is insufficient for capturing extreme timeout issues. While P95 latency may not indicate a timeout, P9999 latency could be significantly high, leading to potential misjudgments and overlooked performance issues.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.