streamhelper: don't cut down connection when subscription stream closed

[YuJuncen]

What problem does this PR solve?

Issue Number: close #58691

Problem Summary:
After a subcription connection cut down by context canceled or EOF, it won't be re-established.
In fact we can reconnect.

What changed and how does it work?

Always report the error to upper level and let them decide whether to retry.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.5533%. Comparing base (eaa39c9) to head (7ff4b77).
Report is 919 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #59559        +/-   ##
================================================
+ Coverage   72.9996%   76.5533%   +3.5537%     
================================================
  Files          1693       1753        +60     
  Lines        468156     497457     +29301     
================================================
+ Hits         341752     380820     +39068     
+ Misses       105370      94271     -11099     
- Partials      21034      22366      +1332     

Flag	Coverage Δ
integration	50.3509% <0.0000%> (?)
unit	73.8573% <100.0000%> (+1.3193%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (∅)
parser	∅ <ø> (∅)
br	65.5677% <100.0000%> (+19.0614%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[YuJuncen]

/test mysql-test

[tiprow]

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• br/OWNERS [3pointer,BornChanger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-03-06 07:32:41.147148464 +0000 UTC m=+513274.276068201: ☑️ agreed by 3pointer.
• 2025-03-06 08:25:51.021221537 +0000 UTC m=+516464.150141281: ☑️ agreed by BornChanger.

[BornChanger]

/retest

[tiprow]

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[YuJuncen]

/retest-required

[YuJuncen]

/ok-to-test

[tiprow]

@YuJuncen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tidb_parser_test	7ff4b77	link	true	/test tidb_parser_test
fast_test_tiprow	7ff4b77	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[YuJuncen]

/test check-dev2

[YuJuncen]

/test pull-br-integration-test

[tiprow]

@YuJuncen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@YuJuncen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[YuJuncen]

/test check-dev2

[tiprow]

@YuJuncen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[YuJuncen]

/run-cherry-picker

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #62573.

[YuJuncen]

/run-cherry-picker

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #62613.
But this PR has conflicts, please resolve them!

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #62614.
But this PR has conflicts, please resolve them!

[Leavrth]

/cherrypick release-8.5-20250114-v8.5.0

[ti-chi-bot]

@Leavrth: new pull request created to branch release-8.5-20250114-v8.5.0: #62635.

Details

In response to this:

/cherrypick release-8.5-20250114-v8.5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.