Skip to content

planner, executor: add PARAMS column to the output of show traffic jobs#59872

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
djshow832:add_param
Mar 4, 2025
Merged

planner, executor: add PARAMS column to the output of show traffic jobs#59872
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
djshow832:add_param

Conversation

@djshow832
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #59871

Problem Summary:
The only way to see the parameters is to check tiproxy logs, which is unfriendly.

What changed and how does it work?

Add an extra column PARAMS to the output of show traffic jobs

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
mysql> show traffic jobs;
+----------------------------+----------------------------+----------------+---------+----------+--------+-------------+----------------------------------------------------------------------------+
| START_TIME                 | END_TIME                   | INSTANCE       | TYPE    | PROGRESS | STATUS | FAIL_REASON | PARAMS                                                                     |
+----------------------------+----------------------------+----------------+---------+----------+--------+-------------+----------------------------------------------------------------------------+
| 2025-03-03 18:53:09.000000 | 2025-03-03 18:53:10.000000 | 127.0.0.1:3080 | replay  | 0%       | done   |             | INPUT="/tmp/traffic", USER="root", SPEED=0.000000, READ_ONLY=false         |
| 2025-03-03 18:52:58.000000 | 2025-03-03 18:53:08.000000 | 127.0.0.1:3080 | capture | 100%     | done   |             | OUTPUT="/tmp/traffic", DURATION="10s", COMPRESS=true, ENCRYPTION_METHOD="" |
+----------------------------+----------------------------+----------------+---------+----------+--------+-------------+----------------------------------------------------------------------------+
2 rows in set (0.02 sec)

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 3, 2025
@tiprow
Copy link
Copy Markdown

tiprow bot commented Mar 3, 2025

Hi @djshow832. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.3549%. Comparing base (448649e) to head (07af943).
Report is 5 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59872        +/-   ##
================================================
+ Coverage   72.9395%   73.3549%   +0.4153%     
================================================
  Files          1699       1700         +1     
  Lines        469556     470721      +1165     
================================================
+ Hits         342492     345297      +2805     
+ Misses       105948     104384      -1564     
+ Partials      21116      21040        -76     
Flag Coverage Δ
integration 42.8109% <22.2222%> (?)
unit 72.2156% <100.0000%> (+0.0671%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 44.3663% <ø> (-0.5793%) ⬇️

@djshow832 djshow832 requested review from AilinKid and xhebox March 3, 2025 12:01
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 3, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 4, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 4, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-03 13:33:02.13379037 +0000 UTC m=+275695.262710115: ☑️ agreed by xhebox.
  • 2025-03-04 06:32:59.891943095 +0000 UTC m=+336893.020862839: ☑️ agreed by AilinKid.

@djshow832
Copy link
Copy Markdown
Contributor Author

/retest

@tiprow
Copy link
Copy Markdown

tiprow bot commented Mar 4, 2025

@djshow832: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@djshow832
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 4, 2025
@djshow832
Copy link
Copy Markdown
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit bbb9623 into pingcap:master Mar 4, 2025
24 checks passed
@djshow832 djshow832 deleted the add_param branch March 4, 2025 09:24
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a parameter column to the output of show traffic jobs

3 participants