Skip to content

br: fix pitr system table inconsistency issue#60202

Merged
ti-chi-bot[bot] merged 8 commits intopingcap:masterfrom
Tristan1900:fix-system-table
Mar 21, 2025
Merged

br: fix pitr system table inconsistency issue#60202
ti-chi-bot[bot] merged 8 commits intopingcap:masterfrom
Tristan1900:fix-system-table

Conversation

@Tristan1900
Copy link
Copy Markdown
Contributor

@Tristan1900 Tristan1900 commented Mar 21, 2025

What problem does this PR solve?

Issue Number: close #60201

Problem Summary:

What changed and how does it work?

Prevent pitr to restore system table change during log backup,
only restore full snapshot to be consistent with previous version

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2025
@tiprow
Copy link
Copy Markdown

tiprow bot commented Mar 21, 2025

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@Tristan1900
Copy link
Copy Markdown
Contributor Author

/hold
wait for tests

@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-release-9.0-beta.1 and removed do-not-merge/needs-triage-completed labels Mar 21, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7645%. Comparing base (1c90ae7) to head (13bbd01).
Report is 11 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60202        +/-   ##
================================================
+ Coverage   73.1634%   74.7645%   +1.6010%     
================================================
  Files          1708       1724        +16     
  Lines        471656     474320      +2664     
================================================
+ Hits         345080     354623      +9543     
+ Misses       105412      97725      -7687     
- Partials      21164      21972       +808     
Flag Coverage Δ
integration 46.2996% <100.0000%> (?)
unit 72.3310% <12.5000%> (-0.0247%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 62.3180% <100.0000%> (+15.0948%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 21, 2025
BornChanger and others added 2 commits March 21, 2025 16:11
Co-authored-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com>
Co-authored-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 21, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-21 03:57:23.411566783 +0000 UTC m=+587137.095802879: ☑️ agreed by Leavrth.
  • 2025-03-21 08:12:27.762987372 +0000 UTC m=+602441.447223468: ☑️ agreed by BornChanger.

@Leavrth
Copy link
Copy Markdown
Contributor

Leavrth commented Mar 21, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2025
@Leavrth
Copy link
Copy Markdown
Contributor

Leavrth commented Mar 21, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 21, 2025
@Leavrth
Copy link
Copy Markdown
Contributor

Leavrth commented Mar 21, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0d74a99 into pingcap:master Mar 21, 2025
34 checks passed
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-9.0-beta.1: #60210.

disksing pushed a commit to oh-my-tidb/tidb that referenced this pull request Mar 27, 2025
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Tristan1900 added a commit to Tristan1900/tidb that referenced this pull request Jun 4, 2025
Tristan1900 added a commit to Tristan1900/tidb that referenced this pull request Jun 5, 2025
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Dec 1, 2025
Leavrth pushed a commit to Leavrth/tidb that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-9.0-beta.1 ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

br: pitr doesn't support system restore yet

4 participants