br: add ddl test for pitr online filter#61631
br: add ddl test for pitr online filter#61631ti-chi-bot[bot] merged 11 commits intopingcap:masterfrom
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
release-note-none
|
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61631 +/- ##
================================================
+ Coverage 73.1132% 74.8085% +1.6952%
================================================
Files 1729 1776 +47
Lines 481044 494596 +13552
================================================
+ Hits 351707 370000 +18293
+ Misses 107810 101466 -6344
- Partials 21527 23130 +1603
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ti-chi-bot
bot
added
size/XXL
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
Tristan1900
force-pushed
the
add_ddl_test_for_pitr_online_filter
branch
from
6a18835 to
0dfa2a2
Compare
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
|
/retest |
|
@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
|
/lgtm |
|
/hold for a final look before merging |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
@Tristan1900: Your lgtm message is repeated, so it is ignored. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Tristan1900: once the present PR merges, I will cherry-pick it on top of release-8.5-20250114-v8.5.0 in the new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
| SchemaID: schemaID, | ||
| TableID: tableID, | ||
| Version: diff.Version, | ||
| Type: model.ActionDropTable, |
There was a problem hiding this comment.
will the refresh meta handle the partition rather than table? if so, do we need modify the schemadiff.Type base on table/partion?
There was a problem hiding this comment.
No, it only handles logical tables (not partitions) and databases.
| -- ActionModifyColumn | ||
| create table test_snapshot_db_create.t_modify_column (id int); | ||
|
|
||
| -- ActionRenameTable |
There was a problem hiding this comment.
can you add ActionRenameSchema/ActionRenameSequence?
There was a problem hiding this comment.
we don't see ActionRenameSchema and ActionRenameSequence in the DDL code list, I don't think we support these operations?
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
@Leavrth: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
@Tristan1900: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, GMHDBJD, Tristan1900 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-8.5-20250114-v8.5.0 |
|
@Tristan1900: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
5 participants
What problem does this PR solve?
Issue Number: ref #61525
Problem Summary:
need ddl cases to cover refresh meta ddl
What changed and how does it work?
add ddl test for pitr online filter
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.