Skip to content

foreign key: check referenced column compatibility when modify column#62796

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
fzzf678:fix_59705
Aug 5, 2025
Merged

foreign key: check referenced column compatibility when modify column#62796
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
fzzf678:fix_59705

Conversation

@fzzf678
Copy link
Copy Markdown
Contributor

@fzzf678 fzzf678 commented Aug 4, 2025

What problem does this PR solve?

Issue Number: close #59705

Problem Summary:

What changed and how does it work?

For foreign key constraint, we should check the new column and referenced column compatibility, Incompatible column shouldn't be modified. #59705 (comment)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2025
@tiprow
Copy link
Copy Markdown

tiprow bot commented Aug 4, 2025

Hi @fzzf678. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fzzf678
Copy link
Copy Markdown
Contributor Author

fzzf678 commented Aug 4, 2025

/retest

@tiprow
Copy link
Copy Markdown

tiprow bot commented Aug 4, 2025

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.8555%. Comparing base (589487a) to head (152842c).
⚠️ Report is 568 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #62796        +/-   ##
================================================
+ Coverage   72.8112%   74.8555%   +2.0443%     
================================================
  Files          1786       1832        +46     
  Lines        487146     495533      +8387     
================================================
+ Hits         354697     370934     +16237     
+ Misses       110806     101554      -9252     
- Partials      21643      23045      +1402     
Flag Coverage Δ
integration 48.8236% <50.0000%> (?)
unit 72.2940% <50.0000%> (+0.1069%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 63.2146% <ø> (+16.8662%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fzzf678
Copy link
Copy Markdown
Contributor Author

fzzf678 commented Aug 4, 2025

/retest

@tiprow
Copy link
Copy Markdown

tiprow bot commented Aug 4, 2025

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 5, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 5, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Aug 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-05 02:34:03.143787054 +0000 UTC m=+321953.286548229: ☑️ agreed by tangenta.
  • 2025-08-05 04:34:07.647126462 +0000 UTC m=+329157.789887637: ☑️ agreed by CbcWestwolf.

@fzzf678
Copy link
Copy Markdown
Contributor Author

fzzf678 commented Aug 5, 2025

/retest

@tiprow
Copy link
Copy Markdown

tiprow bot commented Aug 5, 2025

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fzzf678
Copy link
Copy Markdown
Contributor Author

fzzf678 commented Aug 5, 2025

/retest

@tiprow
Copy link
Copy Markdown

tiprow bot commented Aug 5, 2025

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fzzf678
Copy link
Copy Markdown
Contributor Author

fzzf678 commented Aug 5, 2025

/retest

@tiprow
Copy link
Copy Markdown

tiprow bot commented Aug 5, 2025

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fzzf678
Copy link
Copy Markdown
Contributor Author

fzzf678 commented Aug 5, 2025

/retest

@tiprow
Copy link
Copy Markdown

tiprow bot commented Aug 5, 2025

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fzzf678
Copy link
Copy Markdown
Contributor Author

fzzf678 commented Aug 5, 2025

/retest

@tiprow
Copy link
Copy Markdown

tiprow bot commented Aug 5, 2025

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Aug 5, 2025

@fzzf678: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
non-block/pull-mysql-client-test-next-gen 0920dc2 link false /test pull-mysql-client-test-next-gen
non-block/pull-mysql-test-next-gen 0920dc2 link false /test pull-mysql-test-next-gen
non-block/pull-integration-e2e-test-next-gen 0920dc2 link false /test pull-integration-e2e-test-next-gen
non-block/pull-unit-test-next-gen 152842c link false /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 1853a13 into pingcap:master Aug 5, 2025
26 of 27 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 28, 2025
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #64754.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Foreign key is not updated when changing column name and type

4 participants