Skip to content

br: fix update restore task heartbeat by local time#64266

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
Leavrth:fix-update-restore-status-by-correct-time-zone
Nov 5, 2025
Merged

br: fix update restore task heartbeat by local time#64266
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
Leavrth:fix-update-restore-status-by-correct-time-zone

Conversation

@Leavrth
Copy link
Copy Markdown
Contributor

@Leavrth Leavrth commented Nov 4, 2025

What problem does this PR solve?

Issue Number: close #64247

Problem Summary:
update restore task heartbeat by local time

What changed and how does it work?

fix update restore task heartbeat by utc time

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. Set global timezone
mysql> SET GLOBAL time_zone = '+10:00';
Query OK, 0 rows affected (0.01 sec)
  1. restore failed
  2. restore again
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2025
@tiprow
Copy link
Copy Markdown

tiprow bot commented Nov 4, 2025

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.8611%. Comparing base (749c973) to head (879efc5).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64266        +/-   ##
================================================
+ Coverage   72.7381%   74.8611%   +2.1230%     
================================================
  Files          1859       1860         +1     
  Lines        503905     506451      +2546     
================================================
+ Hits         366531     379135     +12604     
+ Misses       115136     104440     -10696     
- Partials      22238      22876       +638     
Flag Coverage Δ
integration 45.7683% <85.0000%> (?)
unit 72.7122% <0.0000%> (+0.4046%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 62.7728% <85.0000%> (+16.3874%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 5, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 5, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Nov 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-05 08:35:31.982665573 +0000 UTC m=+259181.425695452: ☑️ agreed by 3pointer.
  • 2025-11-05 08:51:13.91107014 +0000 UTC m=+260123.354100019: ☑️ agreed by YuJuncen.

@Leavrth
Copy link
Copy Markdown
Contributor Author

Leavrth commented Nov 5, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 5, 2025
@Leavrth
Copy link
Copy Markdown
Contributor Author

Leavrth commented Nov 5, 2025

/test mysql-test

@tiprow
Copy link
Copy Markdown

tiprow bot commented Nov 5, 2025

@Leavrth: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 16e461a into pingcap:master Nov 5, 2025
30 checks passed
Leavrth added a commit to Leavrth/tidb that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore from checkpoint fails after interruption: “task already exists and is running”

3 participants