Skip to content

executor: fix the order of printing TTL info in show create table#64877

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
YangKeao:fix-64876
Dec 6, 2025
Merged

executor: fix the order of printing TTL info in show create table#64877
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
YangKeao:fix-64876

Conversation

@YangKeao
Copy link
Copy Markdown
Member

@YangKeao YangKeao commented Dec 5, 2025

What problem does this PR solve?

Issue Number: close #64876

Problem Summary:

The result of show create table of TTL+PARTITION table is not correct, which blocks the BR/CDC to synchronize the DDL event.

What changed and how does it work?

  1. Move the partition definition to the bottom part of the show create table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2025
@YangKeao YangKeao requested a review from lcwangchao December 5, 2025 08:28
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.5996%. Comparing base (00d697f) to head (6cf7280).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64877        +/-   ##
================================================
- Coverage   74.6711%   73.5996%   -1.0716%     
================================================
  Files          1891       1870        -21     
  Lines        515863     508895      -6968     
================================================
- Hits         385201     374545     -10656     
- Misses       106806     112193      +5387     
+ Partials      23856      22157      -1699     
Flag Coverage Δ
integration 41.9335% <100.0000%> (-6.2301%) ⬇️
unit 72.7837% <100.0000%> (+0.5275%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.4586% <ø> (-16.2123%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Dec 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-05 09:21:44.838734642 +0000 UTC m=+600849.652512204: ☑️ agreed by lcwangchao.
  • 2025-12-05 09:27:33.801164272 +0000 UTC m=+601198.614941854: ☑️ agreed by hawkingrei.

@YangKeao
Copy link
Copy Markdown
Member Author

YangKeao commented Dec 5, 2025

/retest

3 similar comments
@YangKeao
Copy link
Copy Markdown
Member Author

YangKeao commented Dec 5, 2025

/retest

@hawkingrei
Copy link
Copy Markdown
Member

/retest

@hawkingrei
Copy link
Copy Markdown
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 52505cc into pingcap:master Dec 6, 2025
29 checks passed
@YangKeao YangKeao added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Dec 8, 2025
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #64895.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #64896.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #64897.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #64898.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #64899.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SHOW CREATE TABLE cannot generate valid CREATE TABLE when there are both TTL and Partitions

4 participants