chore: Fix CounterTest created timestamp flake#2049
Merged
zeitlinger merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
jaydeluca
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Relaxed the
CounterTest.testTotalStrippedFromNameprotobuf text assertion socreated_timestampaccepts both forms emitted by protobuf text format:created_timestamp { seconds: ... nanos: ... }created_timestamp { seconds: ... }Why
This test was flaky when the created timestamp landed exactly on a whole-second boundary. In that case, protobuf text format omits the
nanosfield when it is zero, but the test requirednanosto always be present.Impact
This does not change product behavior. It removes a nondeterministic test failure in CI by matching the actual protobuf output contract more accurately.
Root cause
The assertion encoded a stronger formatting assumption than protobuf guarantees.
protobuf-javamay omit zero-valuednanosin text output.Validation
./mvnw test -pl prometheus-metrics-core -Dtest=CounterTest#testTotalStrippedFromName -Dcoverage.skip=true -Dcheckstyle.skip=truemise run build