Cleanup and naming config#5
Open
Andrew Gearhart (AndrewGearhart) wants to merge 2 commits intomainfrom
Open
Conversation
… the project - Updated README.md to include environment and naming guidelines for multi-environment deployments. - Modified app.py to support environment-specific naming for resources and tags. - Adjusted Dockerfiles to remove hardcoded AWS region and rely on task execution environment. - Refactored secret retrieval in autotag.py and main.py files to use dynamic naming based on environment variables. - Updated JavaScript files to utilize environment variables for AWS region configuration.
Andrew Gearhart (AndrewGearhart)
linked an issue
5 tasks
Jim Campbell (lauterman)
approved these changes
Sep 5, 2025
Jim Campbell (lauterman)
left a comment
Jim Campbell (lauterman)
left a comment
There was a problem hiding this comment.
This fits the pattern we're striving for, nice job. Who is bg?
Member
Author
|
Repeating for the good of the order... bg = blue green ... it's just a non-standard example if we had some reason to put together an environment that wasn't specific to one of our standard cluster arguments. |
Alex Kiessling (ajkiessl)
approved these changes
Sep 30, 2025
Collaborator
Alex Kiessling (ajkiessl)
left a comment
Alex Kiessling (ajkiessl)
left a comment
There was a problem hiding this comment.
🔥 🔥 🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces environment-aware naming and configuration across the project to simplify multi-environment deployments (e.g., dev, prod). It standardizes how AWS resources are named and accessed, updates documentation and deployment instructions, and ensures that secrets and resource names are properly namespaced by environment and project. The changes affect the CDK stack, Lambda functions, Docker containers, and supporting scripts.
This will hopefully address #4
Environment-aware resource naming and configuration:
All major AWS resources (S3 buckets, ECS clusters, Lambda functions, Step Functions, CloudWatch dashboards, log groups) now use namespaced patterns based on
<stackBase>-<env>, with account and region included where required for uniqueness. This applies to both CDK resource definitions and runtime environment variables. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Lambda functions and ECS tasks receive
STACK_BASEandENVas environment variables, and resource policies are updated to reference secrets and buckets using these environment-aware names. [1] [2] [3]Documentation and deployment workflow:
README.mdis updated with detailed instructions for environment-aware deployments, including new naming conventions, CDK context usage, and secrets management. Example deployment commands and secret naming patterns are provided. [1] [2] [3] [4]Secrets and configuration management:
/<stackBase>/<env>/client_credentials), instead of a hardcoded path. [1] [2] [3]Container and runtime environment:
These changes make the project more robust, flexible, and ready for multi-environment and multi-account AWS deployments.