Add 100+ fonts from jave.de Figlet Fonts collection v4.0#46
Add 100+ fonts from jave.de Figlet Fonts collection v4.0#46pwaller merged 4 commits intopwaller:masterfrom minchinweb:more-fonts
Conversation
Thanks! P.S. I'm fairly busy so if I don't respond for a couple of weeks please send pings! |
|
Ping! |
Jokes aside, figuring out the licensing is rather annoying. The original download is here: the zip file is almost 8 years old, has multiple authors, appears to be a complication from several sources going back 20+ years, and doesn't include a Figlet 2.0 (New BSD License?)
Figlet 2.1 (New BSD License?)
Figlet 2.2 (New BSD License?)
Figlet 2.2.2 (New BSD License?)
Various Authors, permissive licensing in raw file
No Contact LeadsAuthor Unknown
Author 'known', Dead webpage
No Email Given
Email given
|
|
The commits have been force pushed here, now removing the Travis-CI addition of Python 3.5 (now in Pull Request #48) and changes to |
|
Thanks for following up looks like you put in a fair effort there!. Please bear with me while I go on holiday. Ping me if I don't respond within two weeks. ☺ On 30 January 2016 20:38:44 GMT+00:00, MinchinWeb notifications@github.com wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
|
Ping! Any progress on your end? |
|
ping? Hope your holiday was amazing! |
pyfiglet/test.py
Outdated
| print("Unicode Error handling font {}".format(font)) | ||
| outputFiglet = '' | ||
| except e: | ||
| raise e |
There was a problem hiding this comment.
This except e: raise e looks superfluous?
There was a problem hiding this comment.
Probably. It if was anything other than a UnicodeDecodeError, I didn't want it to go by un-noticed.
Improvements at @pwaller's suggestion.
|
Sounds great. I'll leave it in your capable hands! |
|
v0.7.5 released with this in it. Thanks for your patience. |
|
(Also, please test and let me know if you spot anything wrong :) |
|
I've downloaded it off PyPI and done some quick testing and everything seems to be working as expected! |
these fonts are taken from http://www.jave.de/figlet/fonts.html