feat(workflows): add gh release instead of ncipollo/release-action#1392
Open
dzhalaevd wants to merge 3 commits intopytest-dev:mainfrom
Open
feat(workflows): add gh release instead of ncipollo/release-action#1392dzhalaevd wants to merge 3 commits intopytest-dev:mainfrom
dzhalaevd wants to merge 3 commits intopytest-dev:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1392 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 2 2
Lines 473 473
Branches 57 57
=======================================
Hits 450 450
Misses 17 17
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dzhalaevd
commented
Apr 1, 2026
Author
dzhalaevd
left a comment
There was a problem hiding this comment.
I think this is ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Due to security issues with
ncipollo/release-actionneed to remove this dependency and replace withgh releaseCloses: #1382
Related: #1382
How it was fixed?
The release logic previously implemented via
ncipollo/release-actionhas been reimplemented using theghOur workflow now relied on two key flags:
allowUpdates: trueskipIfReleaseExists: trueThese flags overlap in behavior at least semantically and the ncipollo documentation doesn't clearly define their interaction or precedence. Based on the existing workflow, i was reimplemented as follows with this idea:
I tried run jobs for check how release creating here
and re-run for checking how it was updates