network collector: sanitize device names with dots#507
Open
jnoss wants to merge 1 commit intopython-diamond:masterfrom
Open
network collector: sanitize device names with dots#507jnoss wants to merge 1 commit intopython-diamond:masterfrom
jnoss wants to merge 1 commit intopython-diamond:masterfrom
Conversation
This sanitizes network device names (such as vlans) containing '.' to have '_' instead, to preserve metric path structure. Addresses issue python-diamond#66
jnoss
force-pushed
the
fix_network_collector_vlan_device_names
branch
from
95d3513 to
d35959c
Compare
Member
|
Can you update the tests to make sure this is tested? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sanitizes network device names (such as vlans) containing '.' to
have '_' instead, to preserve metric path structure. Addresses issue #66