Skip to content

Netscaler: Use vserver full name in metric path#524

Open
jdoupe wants to merge 1 commit intopython-diamond:masterfrom
jdoupe:netscaler-fix-vserver-name
Open

Netscaler: Use vserver full name in metric path#524
jdoupe wants to merge 1 commit intopython-diamond:masterfrom
jdoupe:netscaler-fix-vserver-name

Conversation

@jdoupe
Copy link
Copy Markdown

@jdoupe jdoupe commented Aug 23, 2016

If a vserver name is over 30 characters, the netscaler generates a hashed version of the name in the vserverName. This patch will pull the vserverFullName and use that in the metric path name instead of the hashed name.

@jdoupe jdoupe changed the title Use vserver full name in metric path Netscaler: Use vserver full name in metric path Aug 23, 2016
@jdoupe jdoupe force-pushed the netscaler-fix-vserver-name branch from 8cc77e3 to 26b8e48 Compare August 25, 2016 14:20
@jdoupe jdoupe force-pushed the netscaler-fix-vserver-name branch from 26b8e48 to 64b4058 Compare August 25, 2016 14:48
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 25, 2016

Coverage Status

Coverage remained the same at 59.386% when pulling 64b4058 on jdoupe:netscaler-fix-vserver-name into fa8da84 on python-diamond:master.

@shortdudey123
Copy link
Copy Markdown
Member

shortdudey123 commented Aug 25, 2016

Should there be a config option to flip between the full name and hashed name? then it makes it a non-breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants