Netscaler: Use vserver full name in metric path#524
Open
jdoupe wants to merge 1 commit intopython-diamond:masterfrom
Open
Netscaler: Use vserver full name in metric path#524jdoupe wants to merge 1 commit intopython-diamond:masterfrom
jdoupe wants to merge 1 commit intopython-diamond:masterfrom
Conversation
8cc77e3 to
26b8e48
Compare
26b8e48 to
64b4058
Compare
Member
|
Should there be a config option to flip between the full name and hashed name? then it makes it a non-breaking change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a vserver name is over 30 characters, the netscaler generates a hashed version of the name in the vserverName. This patch will pull the vserverFullName and use that in the metric path name instead of the hashed name.