timeout functions now raise ValueError on NaN inputs#2667
timeout functions now raise ValueError on NaN inputs#2667jakkdl merged 1 commit intopython-trio:masterfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2667 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 118 118
Lines 16534 16539 +5
Branches 3001 3003 +2
=======================================
+ Hits 16222 16227 +5
Misses 254 254
Partials 58 58
|
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
Looks good. 1 genuine comment and 2 filler comments.
| Args: | ||
| seconds (float): The timeout. | ||
|
|
There was a problem hiding this comment.
Just a comment that I really don't like how this is so easy to forget :S
There was a problem hiding this comment.
This sounds like something that can be auto-generated / have the signature displayed in another manner in the doc, once the public interface is fully typed.
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
Actually, I just remembered changes like this should probably get a newsfragment!
Hah! I've been working so much solely on internal stuff I completely forgot this was a thing, good catch! Feel free to merge if it looks good otherwise 🚀 |
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
Small nitpick. breaking does feel a bit far out but honestly that is probably the best category.
I'll merge (or you can) after blocking CI is fixed.
| @@ -0,0 +1 @@ | |||
| Timeout functions now raise `ValueError` if passed `nan`. This includes `trio.sleep`, `trio.sleep_until`, `trio.move_on_at`, `trio.move_on_after`, `trio.fail_at` and `trio.fail_after`. | |||
There was a problem hiding this comment.
I'd rather "NaN" over "nan"
2 participants
Fixes #2493
Consolidated all
ValueErrortests into a single test.