bpo-28814: Undeprecate inadvertantly deprecated inspect function. by Carreau · Pull Request #122 · python/cpython

Carreau · 2017-02-15T16:54:25Z

Nick Coghlan said on bpo-28814:

inspect.getargvalues() and inspect.formatargvalues() were deprecated
in Python 3.5 as part of implementing bpo-20438

This is incorrect, as these are frame introspection related functions,
not callable introspection ones. The documentation and implementation
layout is confusing though, as they're interleaved with the callable
introspection operation

So un-deprecate in the doc, and leave a note to ignore previous
deprecation notice.

Carreau · 2017-02-15T16:55:26Z

The documentation and implementation
layout is confusing though, as they're interleaved with the callable
introspection operation

I did not touch the code but I'll be happy to move these 2 functions into the "stack frame extraction" section of inspect.py

ncoghlan · 2017-02-18T04:43:23Z

Accidentally doubled word here: s/with with/with/

ncoghlan · 2017-02-18T04:43:57Z

Thanks! This mostly looks good to me, just one accidentally doubled word to fix before it can be merged.

berkerpeksag · 2017-02-19T20:01:15Z

typo: inadvertently

"Ignore previous deprecation notice." is superfluous and can be deleted in my opinion.

berkerpeksag · 2017-02-19T20:03:38Z

Function -> Functions

Indentation should use 3 or 4 spaces:

.. note:: Functions [...]

Or start with:

:func:`~inspect.getargvalues` and :func:`~inspect.formatargvalues` functions were inadvertently [...]

I'm not a native speaker so I hope @ncoghlan will chime in here :)

berkerpeksag · 2017-02-19T20:06:31Z

typo: inadvertantly -> inadvertently

Please add a dot at the end of the sentence.

Carreau · 2017-02-20T23:35:53Z

Thanks ! Comments addressed.

berkerpeksag

Looks pretty good to me, just left two minor comments :)

berkerpeksag · 2017-02-21T07:37:38Z

You forgot to end the sentence with a full stop :)

berkerpeksag · 2017-02-21T07:38:52Z

Looking at this again, I think using a note directive is not needed in 3.5 whatsnew page.

Do you mean removing the .. note:: altogether along with the text, or just demote the text to a plain paragraph ?

Sorry, I wasn't clear in my earlier comment. I meant the latter one.

Ok, Done. And full stop added at the end.

Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation So un-deprecate in the doc, and leave a note to ignore previous deprecation notice.

berkerpeksag · 2017-02-22T05:46:00Z

Thanks!

Carreau · 2017-02-22T18:23:22Z

Thanks!

Thanks as well.

…ython#122) Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation This commit undeprecates these functions and adds a note to ignore previous deprecation notices. (cherry picked from commit 0899b98)

ncoghlan · 2017-02-23T05:03:43Z

@berkerpeksag Thanks, you picked up several things I missed :)

) (#243) Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation This commit undeprecates these functions and adds a note to ignore previous deprecation notices. (cherry picked from commit 0899b98)

) (#244) Nick Coghlan said on bpo-28814: > inspect.getargvalues() and inspect.formatargvalues() were deprecated > in Python 3.5 as part of implementing bpo-20438 > This is incorrect, as these are *frame* introspection related functions, > not callable introspection ones. The documentation and implementation > layout is confusing though, as they're interleaved with the callable > introspection operation This commit undeprecates these functions and adds a note to ignore previous deprecation notices. (cherry picked from commit 0899b98)

The cache caused false block leak errors from test suite --huntrleaks / -R runs. The performance penalty is irrelevant in debug builds. https://bitbucket.org/stackless-dev/stackless/issues/122

Reinstates block_map_n294_chain at 150 arms (n≈302 BBs) — the wiring fixture that exposed the Phoenix-introduced D-1775660617 RPO un-clamp bug at push 42 (then HALT'd via SIGABRT). Push 43 (4feb0d2) closed the bug; this push restores the canary now that it legitimately PASSes. Test entries: n=0/74/149/200 (low/mid/high-arm + default-miss path coverage), all asserted force_compile + correct execution. Coverage role: - 110-arm fixture (push 41, n≈223 BBs, no resize) — covers below-256 code path - 150-arm fixture (this commit, n≈302 BBs, resize-triggered) — covers >256 code path that GitRPOTraversal + un-clamped wrapper now handle - Together: empirical pair on the same fn-shape exercising both paths of hir_cfg_get_rpo + the cap=4096 paths in pass_output_type_c.c Coverage-Trigger Rule (Phoenix-presumed-regression policy, Alex 13:47:22Z + 13:48:14Z; advisory per supervisor 13:18:54Z): re-grep of parked-bug list (docs/parked-bug-audit-2026-04-24.md Groups A+C; 8 items) against the n≈302 BB fixture surface returns ZERO newly-reachable items (see chat 14:42:05Z for per-item disposition). Push 44 is the rule's first practical test; honoured-in-the-letter at birth. A/B coverage (pythia python#122 python#3 follow-up) discharged STRUCTURALLY per theologian 14:41:27Z: GetRPOTraversal is deterministic on CFG state; the cap parameter controls only caller-buffer write count, not algorithm output. Same-function pre-sized-vs-resize empirical A/B (option i) would require a debug-only cap-setter knob (multi-hour infra) and would add empirical-on-empirical, not new evidence about the determinism claim. Tie-breaking happens INSIDE GetRPOTraversal which receives the CFG, not the caller's output buffer; caller-buffer realloc cannot reach that surface. Pre-commit discipline: bash -n PASS; no C/C++ source touched (push 43 binary 4feb0d2 remains current per testkeeper 14:42:44Z). Auth chain: theologian 13:46:04Z (A/B fold-in proposal) + 14:41:27Z ((ii) APPROVE + structural defense); supervisor 14:39:27Z (push 43 + push 44 plan) + 14:41:00Z (proceed-(ii)-unless-objected); testkeeper pre-commit lint 14:42:44Z; alex 13:47:22Z + 13:48:14Z policy directives.

the-knights-who-say-ni added the CLA signed label Feb 15, 2017

ncoghlan reviewed Feb 18, 2017

View reviewed changes

Comment thread Doc/whatsnew/3.5.rst Outdated

Copy link
Copy Markdown

Contributor

ncoghlan Feb 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally doubled word here: s/with with/with/

berkerpeksag requested changes Feb 19, 2017

View reviewed changes

Carreau force-pushed the undeprecate branch from dbcffb0 to f90fb68 Compare February 20, 2017 23:34

berkerpeksag added needs backport to 3.5 labels Feb 21, 2017

berkerpeksag requested changes Feb 21, 2017

View reviewed changes

Carreau force-pushed the undeprecate branch from f90fb68 to e3e6084 Compare February 22, 2017 03:03

berkerpeksag approved these changes Feb 22, 2017

View reviewed changes

berkerpeksag merged commit 0899b98 into python:master Feb 22, 2017

Carreau deleted the undeprecate branch February 22, 2017 18:23

berkerpeksag removed the needs backport to 3.6 label Feb 22, 2017

berkerpeksag removed the needs backport to 3.5 label Feb 22, 2017

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017

merge 3.4-slp (Stackless python#122)

8188f4a

jaraco pushed a commit that referenced this pull request Dec 2, 2022

Update pytest-asyncio from 0.8.0 to 0.9.0 (#122)

066bbc4

gvanrossum mentioned this pull request Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

kemier mentioned this pull request Feb 11, 2025

segmentfault when pip installing setuptools #129992

Open

kemier mentioned this pull request Feb 11, 2025

segmentfault when pip installing setuptools #129993

Closed

Uh oh!

Conversation

Carreau commented Feb 15, 2017

Uh oh!

Carreau commented Feb 15, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ncoghlan commented Feb 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Carreau commented Feb 20, 2017

Uh oh!

berkerpeksag left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

berkerpeksag commented Feb 22, 2017

Uh oh!

Carreau commented Feb 22, 2017

Uh oh!

ncoghlan commented Feb 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants