gh-134370 Added clarification on instances annotations#134387
Merged
JelleZijlstra merged 6 commits intopython:mainfrom May 22, 2025
Merged
Conversation
Instances of classes cannot have annotations, however sometimes they will erroneously have the __annotations__ attribute
willingc
approved these changes
May 20, 2025
Contributor
willingc
left a comment
willingc
left a comment
There was a problem hiding this comment.
These changes look good to me. I would like @JelleZijlstra to also review from a typing perspective. Thank you @AlexKautz.
Author
|
I also swapped a |
JelleZijlstra
approved these changes
May 22, 2025
JelleZijlstra
added
needs backport to 3.13
|
Thanks @AlexKautz for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2025
|
Sorry, @AlexKautz and @JelleZijlstra, I could not cleanly backport this to |
|
GH-134509 is a backport of this pull request to the 3.14 branch. |
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
May 26, 2025
…134387) Instances of classes cannot have annotations, however sometimes they will erroneously have the __annotations__ attribute
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…134387) Instances of classes cannot have annotations, however sometimes they will erroneously have the __annotations__ attribute
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…134387) Instances of classes cannot have annotations, however sometimes they will erroneously have the __annotations__ attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Hello from PyCon sprints!]
Instances of classes cannot have annotations,
however sometimes they will erroneously have the
annotations attribute.
@python/proofreaders could you take a look? This is my first Python documentation writing so I'm sure there's a mistake somewhere :).
📚 Documentation preview 📚: https://cpython-previews--134387.org.readthedocs.build/