gh-133740: Fix regression in locale.nl_langinfo(ALT_DIGITS) by serhiy-storchaka · Pull Request #136237 · python/cpython

serhiy-storchaka · 2025-07-03T10:13:31Z

There is no need to temporary switch locale for items ALT_DIGITS and ERA if the nl_langinfo() result is empty (most locales).

Issue: test_alt_digits_nl_langinfo fails for locale uk_UA #133740

There is no need to temporary switch locale for items ALT_DIGITS and ERA if the nl_langinfo() result is empty (most locales).

miss-islington-app · 2025-07-03T10:39:18Z

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

…thonGH-136237) There is no need to temporary switch locale for items ALT_DIGITS and ERA if the nl_langinfo() result is empty (most locales). (cherry picked from commit 5c984ae) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app · 2025-07-03T10:39:27Z

GH-136240 is a backport of this pull request to the 3.14 branch.

…H-136237) (GH-136240) There is no need to temporary switch locale for items ALT_DIGITS and ERA if the nl_langinfo() result is empty (most locales). (cherry picked from commit 5c984ae) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot · 2025-07-03T11:47:20Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.14 (tier-3) has failed when building commit 150262d.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1722/builds/360) and take a look at the build logs.
Check if the failure is related to this commit (150262d) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1722/builds/360

Failed tests:

test_socketserver

Failed subtests:

test_UnixDatagramServer - test.test_socketserver.SocketServerTest.test_UnixDatagramServer

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 222, in test_UnixDatagramServer
    self.run_server(socketserver.UnixDatagramServer,
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                    socketserver.DatagramRequestHandler,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                    self.dgram_examine)
                    ^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/test/support/threading_helper.py", line 66, in decorator
    return func(*args)
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 133, in run_server
    testfunc(svrcls.address_family, addr)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 160, in dgram_examine
    buf = data = receive(s, 100)
                 ~~~~~~~^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 43, in receive
    raise RuntimeError("timed out on %r" % (sock,))
RuntimeError: timed out on <socket.socket fd=19, family=1, type=2, proto=0, laddr=./test_python_gqej_dwy.sock>


Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 222, in test_UnixDatagramServer
    self.run_server(socketserver.UnixDatagramServer,
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                    socketserver.DatagramRequestHandler,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                    self.dgram_examine)
                    ^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/test/support/threading_helper.py", line 66, in decorator
    return func(*args)
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 133, in run_server
    testfunc(svrcls.address_family, addr)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 160, in dgram_examine
    buf = data = receive(s, 100)
                 ~~~~~~~^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 43, in receive
    raise RuntimeError("timed out on %r" % (sock,))
RuntimeError: timed out on <socket.socket fd=19, family=1, type=2, proto=0, laddr=./test_python_3518neop.sock>


Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/threading.py", line 1081, in _bootstrap_inner
    self._context.run(self.run)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/threading.py", line 1023, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 240, in serve_forever
    self._handle_request_noblock()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 320, in _handle_request_noblock
    self.handle_error(request, client_address)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 318, in _handle_request_noblock
    self.process_request(request, client_address)
    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 349, in process_request
    self.finish_request(request, client_address)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 362, in finish_request
    self.RequestHandlerClass(request, client_address, self)
    ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 768, in __init__
    self.finish()
    ~~~~~~~~~~~^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/2FD4FA50-D055-46C1-A6FE-C5DD437B884B/data/Containers/Bundle/Application/727518F2-A912-4C5B-AB79-01FA73D851D6/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 863, in finish
    self.socket.sendto(self.wfile.getvalue(), self.client_address)
    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ConnectionResetError: [Errno 54] Connection reset by peer
ERROR

…thonGH-136237) There is no need to temporary switch locale for items ALT_DIGITS and ERA if the nl_langinfo() result is empty (most locales).

pythongh-133740: Fix regression in locale.nl_langinfo(ALT_DIGITS)

7160573

There is no need to temporary switch locale for items ALT_DIGITS and ERA if the nl_langinfo() result is empty (most locales).

serhiy-storchaka requested a review from vstinner July 3, 2025 10:13

serhiy-storchaka added skip news needs backport to 3.14 bugs and security fixes labels Jul 3, 2025

bedevere-app Bot added the awaiting core review label Jul 3, 2025

bedevere-app Bot mentioned this pull request Jul 3, 2025

test_alt_digits_nl_langinfo fails for locale uk_UA #133740

Closed

vstinner approved these changes Jul 3, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 3, 2025

serhiy-storchaka enabled auto-merge (squash) July 3, 2025 10:24

serhiy-storchaka merged commit 5c984ae into python:main Jul 3, 2025
49 checks passed

bedevere-app Bot removed the awaiting merge label Jul 3, 2025

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 3, 2025

serhiy-storchaka deleted the locale-nl_langinfo-empty branch July 3, 2025 10:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-133740: Fix regression in locale.nl_langinfo(ALT_DIGITS)#136237

gh-133740: Fix regression in locale.nl_langinfo(ALT_DIGITS)#136237
serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka:locale-nl_langinfo-empty

serhiy-storchaka commented Jul 3, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

Uh oh!

miss-islington-app Bot commented Jul 3, 2025

Uh oh!

bedevere-app Bot commented Jul 3, 2025

Uh oh!

bedevere-bot commented Jul 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

serhiy-storchaka commented Jul 3, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Jul 3, 2025

Uh oh!

bedevere-app Bot commented Jul 3, 2025

Uh oh!

bedevere-bot commented Jul 3, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

serhiy-storchaka commented Jul 3, 2025 •

edited by bedevere-app Bot

Loading