Skip to content

gh-148211: decompose _SHUFFLE_3_LOAD_CONST_INLINE_BORROW in JIT#148816

Merged
markshannon merged 3 commits intopython:mainfrom
NekoAsakura:gh-148211/decompose-shuffle-3
Apr 28, 2026
Merged

gh-148211: decompose _SHUFFLE_3_LOAD_CONST_INLINE_BORROW in JIT#148816
markshannon merged 3 commits intopython:mainfrom
NekoAsakura:gh-148211/decompose-shuffle-3

Conversation

@NekoAsakura
Copy link
Copy Markdown
Contributor

@NekoAsakura NekoAsakura commented Apr 20, 2026

Missed one.

@bedevere-app bedevere-app Bot mentioned this pull request Apr 20, 2026
@NekoAsakura NekoAsakura changed the title gh-148211: decompose _SHUFFLE_2_LOAD_CONST_INLINE_BORROW in JIT gh-148211: decompose _SHUFFLE_3_LOAD_CONST_INLINE_BORROW in JIT Apr 20, 2026
@cocolato
Copy link
Copy Markdown
Member

LGTM, Thanks!

Copy link
Copy Markdown
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@markshannon markshannon merged commit 2b6a137 into python:main Apr 28, 2026
80 checks passed
@markshannon
Copy link
Copy Markdown
Member

Note:

It might be worth adding ROT_3 and a RROT_3 uops to use in the optimizer and the peepholer.
A SWAP_2; SWAP_3 takes 6 moves, but ROT_3 only takes 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants