Skip to content

gh-148973: fix segfault on mismatch between consts size and oparg in compiler#148974

Merged
iritkatriel merged 1 commit intopython:mainfrom
iritkatriel:gh-148973
Apr 25, 2026
Merged

gh-148973: fix segfault on mismatch between consts size and oparg in compiler#148974
iritkatriel merged 1 commit intopython:mainfrom
iritkatriel:gh-148973

Conversation

@iritkatriel
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel commented Apr 24, 2026 •
edited by bedevere-app Bot
Loading

@bedevere-app bedevere-app Bot mentioned this pull request Apr 24, 2026
Closed
StanFromIreland
StanFromIreland approved these changes Apr 25, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iritkatriel iritkatriel merged commit c650b51 into python:main Apr 25, 2026
77 checks passed
@StanFromIreland
Copy link
Copy Markdown
Member

StanFromIreland commented Apr 25, 2026

I think we should backport to at least 3.14, WDYT?

@iritkatriel
Copy link
Copy Markdown
Member Author

iritkatriel commented Apr 25, 2026

Yes, I'm preparing a backport. I assumed the automated back port won't work but I can try it.

@iritkatriel iritkatriel added the needs backport to 3.14 bugs and security fixes label Apr 25, 2026
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Apr 25, 2026

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Apr 25, 2026

GH-148980 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Apr 25, 2026
iritkatriel added a commit that referenced this pull request Apr 25, 2026
@miss-islington @iritkatriel
[3.14] gh-148973: fix segfault on mismatch between consts size and op…
8acb98a 
…arg in compiler (GH-148974) (#148980)

gh-148973: fix segfault on mismatch between consts size and oparg in compiler (GH-148974)
(cherry picked from commit c650b51)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@iritkatriel @ljfp
pythongh-148973: fix segfault on mismatch between consts size and opa…
cb2c0c7 
…rg in compiler (python#148974)
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Apr 25, 2026

GH-148997 is a backport of this pull request to the 3.13 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

_testinternalcapi: optimize_cfg / compiler_codegen const table mismatches cause crashes

2 participants

@iritkatriel @StanFromIreland