bpo-40662: add test for ast.get_source_segment with missing line/col…#20157
Merged
pablogsal merged 3 commits intopython:masterfrom May 18, 2020
Merged
bpo-40662: add test for ast.get_source_segment with missing line/col…#20157pablogsal merged 3 commits intopython:masterfrom
pablogsal merged 3 commits intopython:masterfrom
Conversation
…info, and fix behaviour to match the docstring
remilapeyre
approved these changes
May 18, 2020
remilapeyre
left a comment
remilapeyre
left a comment
There was a problem hiding this comment.
Thanks for the fix and the tests @iritkatriel !
pablogsal
reviewed
May 18, 2020
isidentical
approved these changes
May 18, 2020
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
…plete location information (pythonGH-20157) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a unit test for ast.get_source_segment() on a node that has incomplete location information, expecting None as per the docstring. Added a possible fix to the code.
https://bugs.python.org/issue40662