Skip to content

bpo-43265: Improve sqlite3.Connection.backup error handling#24586

Merged
berkerpeksag merged 4 commits intopython:masterfrom
erlend-aasland:sqlite-backup-error
Apr 14, 2021
Merged

bpo-43265: Improve sqlite3.Connection.backup error handling#24586
berkerpeksag merged 4 commits intopython:masterfrom
erlend-aasland:sqlite-backup-error

Conversation

@erlend-aasland
Copy link
Copy Markdown
Contributor

@erlend-aasland erlend-aasland commented Feb 19, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Feb 19, 2021

cc. @berkerpeksag, @serhiy-storchaka

@erlend-aasland erlend-aasland changed the title bpo-43265: Improve sqlite3 backup error handling bpo-43265: Improve sqlite3.Connection.backup error handling Feb 19, 2021
@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Feb 19, 2021

FYI, I've also tested this with SQLite 3.7.15, FWIW.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 11, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 11, 2021
berkerpeksag
berkerpeksag requested changes Apr 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much cleaner now, thank you! I only have comment and then we can merge it.

Comment thread Modules/_sqlite/connection.c Outdated
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 14, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Apr 14, 2021

This looks much cleaner now, thank you!

Anytime :) Thanks for reviewing! I have made the requested changes; please review again.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 14, 2021

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@berkerpeksag berkerpeksag merged commit c1ae741 into python:master Apr 14, 2021
@erlend-aasland erlend-aasland deleted the sqlite-backup-error branch April 14, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees

No one assigned

Labels

skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @bedevere-bot @berkerpeksag @the-knights-who-say-ni