Renamed whole Mac OS X's to macOS#58
Renamed whole Mac OS X's to macOS#58ergenekonyigit wants to merge 9 commits intopython:masterfrom ergenekonyigit:master
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
| @@ -1,15 +1,15 @@ | |||
| :mod:`macpath` --- Mac OS 9 path manipulation functions | |||
| :mod:`macpath` --- macOS 9 path manipulation functions | |||
There was a problem hiding this comment.
I don't know what is Apple's definition. Is there any resource from Apple?
There was a problem hiding this comment.
@methane Apple called mac OS 9 but there is no source on their website now.
There was a problem hiding this comment.
https://en.wikipedia.org/wiki/MacOS
"OS X" was renamed macOS. But no information about classic "Mac OS".
| +---------------------------+---------------------------------------------+ | ||
| | :const:`KQ_FILTER_NETDEV` | Watch for events on a network device | | ||
| | | [not available on Mac OS X] | | ||
| | | [not available on macOS] | |
| | ``'macosx'`` | :class:`macOS('default')` | \(3) | | ||
| +------------------------+-----------------------------------------+-------+ | ||
| | ``'safari'`` | :class:`MacOSX('safari')` | \(3) | | ||
| | ``'safari'`` | :class:`macOS('safari')` | \(3) | |
ned-deily
left a comment
ned-deily
left a comment
There was a problem hiding this comment.
@ergenekonyigit Thanks for your suggested changes. But I think we need to be more careful here. Many of these changes are incorrect and unnecessary churn. While it is OK to change generic OS references to macOS, it is not correct to refer to macOS versions prior to 10.12. See https://en.wikipedia.org/wiki/MacOS for the standard Apple designations. Also, we should not be changing references in WhatsNew documents for older releases.
|
|
||
| Mac OS X | ||
| macOS | ||
| ^^^^^^^^ |
There was a problem hiding this comment.
Looks like the underline should be fixed here.
| @@ -1,8 +1,8 @@ | |||
| :mod:`plistlib` --- Generate and parse Mac OS X ``.plist`` files | |||
| :mod:`plistlib` --- Generate and parse macOS ``.plist`` files | |||
| ================================================================ | |||
There was a problem hiding this comment.
Underline. There's probably a lot more instances.
|
@ned-deily https://github.com/apple/swift/blob/30dd1a90474032717332f26aca8acbfda427d8bb/test/stdlib/DispatchDeprecationMacOS.swift#L8 Before changing I'm looking in swift source code. Maybe not today but someday i think we have to change them. Look at 11 different variations, this is very complicated, what do you think? |
|
FWIW, I agree with @ned-deily. I suggest to close this PR. |
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 82.37% 82.37% -0.01%
==========================================
Files 1427 1427
Lines 350948 350948
==========================================
- Hits 289102 289094 -8
- Misses 61846 61854 +8Continue to review full report at Codecov.
|
|
I agree w/ @ned-deily and @berkerpeksag about this being unnecessary updates. While we should definitely use the proper term going forward, the docs should just be left as-is. Thanks for the PR regardless, @ergenekonyigit ! |
|
FTR, I'm not opposed to updating references in the current docs as long as they are done carefully and accurately. As @brettcannon suggests, a better way to do that is to make appropriate updates as we move forward with other, more important changes in the various areas. |
Once a core dev approved it and all CI passed.
* Bugfix: increment `interpolationsidx` in `template_new()` * Spec fix: don't return empty strings from `templateiter_next()` --------- Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Push 44 W3 follow-up per supervisor 03:07:52Z + theologian 03:07:25Z: - rc_oracle_self_test.sh: expand from 1 → 4 injection classes (A/B/C/D) - _rc_oracle_adapter.h: add invariant python#7 (oracle lifespan policy) to BRIDGE SPEC TEMPLATE (supersedes W12) Per supervisor 03:07:52Z W4 vacuous-pass defeat directive: "single-injection test is the W4 vacuous-pass class". ================================================================ PART 1: 4 INJECTION CLASSES (rc_oracle_self_test.sh) ================================================================ Generalized inject_class helper (sed → rebuild → diff → restore → rebuild) replaces the hard-coded single-injection block. Class A — refcount BALANCE under-count: Skip FIRST phx_rc_emit_incref via line-comment. Failure mode caught: under-count → leak under Py_REF_DEBUG. Class B — refcount BALANCE over-count: Skip FIRST phx_rc_emit_decref via line-comment. Failure mode caught: over-count → leak (different mechanism than A). Class C — refcount SEQUENCE: Skip SECOND phx_rc_emit_incref (different call-site than A) via line-comment. Failure mode caught: HIR position-dependent divergence — same opcode family as A but different injection position to test position sensitivity. Class D — TYPE LATTICE: Change FIRST HIR_TYPE_OBJECT → HIR_TYPE_NULLPTR via sed. Failure mode caught: type-annotation flip — wrong refcount semantics for borrowed-vs-owned classification. Each class: 1. sed transformation applied 2. cmp -s verifies source actually changed (catches stale sed pattern) 3. Rebuild C path 4. Run scripts/rc_diff_oracle.sh 5. PASS = non-empty diff (oracle CATCHES the divergence) FAIL = empty diff under injection (oracle MISSED → non-functional) 6. Restore source from backup + rebuild Default invocation runs all 4 classes sequentially. --class=A|B|C|D runs single class. trap EXIT ensures restore on script error. ================================================================ PART 2: INVARIANT python#7 (_rc_oracle_adapter.h) ================================================================ Added to BRIDGE SPEC TEMPLATE INVARIANTS PRESERVED section per theologian + supervisor 03:07:52Z (supersedes earlier W12 framing): 7. Oracle lifespan: utility decreases as emit methods diverge from d81e580 baseline. RETIREMENT TRIGGER: when scripts/ rc_diff_oracle.sh on CLEAN run produces >30% pre/post divergence noise, retire (archive script). ESTIMATED LIFESPAN: 30-50 pushes from d81e580 (push 35) → retirement window ~push 65-85. Re-evaluate at push 50 (testkeeper clean-diff noise % post). Also added invariant python#6 inline (oracle scope conflated diff — already in commit msg of a99db92 but missing from header file). Falsifier section expanded to enumerate 4 classes (A/B/C/D) with their distinct failure-mode coverage per Pythia python#58's vacuous-pass concern. ================================================================ VERIFICATION ================================================================ bash -n scripts/rc_oracle_self_test.sh: SYNTAX OK (260 lines). diff --cached --stat: 2 files, +142/-48 — only the 2 intended files (verified explicit-staging discipline per supervisor 02:51:14Z). Push 44 W3 batch grows to 3 commits: a99db92 — W3 Steps 1-4 bundled (scratch lib + dispatcher) 4f591a1 — W3 Step 5 v1 (single class A) THIS COMMIT — W3 Step 5 expansion (4 classes + invariant python#7) ABBA cap 15 → 18.
Per supervisor 2026-04-22 03:06:55Z + theologian 03:07:12Z + pythia python#58: push 44 introduces the W3 R4 oracle dispatcher in compiler.cpp behind #ifdef RC_ORACLE. The push-44 nm production-binary check is one-shot — need a STANDING gate assertion so future compiler.cpp edits cannot silently leak RC_ORACLE dispatch into production. Failure mode caught: Any future commit that drops, inverts, or accidentally hard-defines the #ifdef RC_ORACLE guard would leak the C++ rc_oracle dispatch path (linked from libphoenix_rc_oracle.a) into the production python binary. Without this assertion, the leak is invisible until the next manual nm audit. Same silent-failure class as the cp-||-true loophole (catch python#4, push 38) — accepted bad state silently. Implementation (5 LOC after BINARY_MATCH (clean) ✓): RC_ORACLE_LEAK=$(nm $PYTHON | grep -c 'rc_oracle') if [ $RC_ORACLE_LEAK -ne 0 ]; then echo BINARY_RC_ORACLE_LEAK_DETECTED ... exit 1 fi echo BINARY_RC_ORACLE_OK: production binary clean (0 rc_oracle symbols) Verbatim wording per gatekeeper item python#15 (03:07:25Z): - PASS: 'BINARY_RC_ORACLE_OK: production binary clean (0 rc_oracle symbols)' - FAIL: 'BINARY_RC_ORACLE_LEAK_DETECTED' + FATAL + exit 1 - Mirrors BINARY_DIRTY discipline (catch silent failure structurally) Verification (compile-clean pre-commit): bash -n scripts/gate_phoenix.sh: SYNTAX OK Inserted at line 120 (immediately after BINARY_MATCH block at line 119). Bundled into push 44 (rather than standalone push 45) because the dispatcher lands in this push — the leak-check guards it from day 1 instead of leaving a one-push window where item python#15 isn't enforced. Push 44 batch grows 3 → 4 commits: THIS COMMIT — gate item python#15 (RC_ORACLE leak assertion) 63568c0 — W3 Step 5 expansion (4 injection classes + invariant python#7) 4f591a1 — W3 Step 5 v1 (rc_oracle_self_test.sh) a99db92 — W3 Steps 1-4 (scratch lib + dispatcher) ABBA cap usage: 17 → 18 (4 commits this push).
7 participants
I renamed whole different variations Mac OS X's to macOS
A few different variations I found.
Mac OS ——> macOS
Mac OS X ——> macOS
Mac OSX ——> macOS
MacOS X ——> macOS
Mac OSX ——> macOS
MacOSX ——> macOS
OSX ——> macOS
OS X ——> macOS
With this, everything about macOS can be found comfortably.