Disable miss-islington comments in check_run as well#583
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #583 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1017 1010 -7
Branches 67 66 -1
=========================================
- Hits 1017 1010 -7
|
Mariatta
approved these changes
Oct 4, 2022
ezio-melotti
reviewed
Oct 4, 2022
| # original_pr_number = title_match.group("pr") | ||
| # participants = await util.get_gh_participants( | ||
| # gh, original_pr_number | ||
| # ) |
Member
There was a problem hiding this comment.
Can you elaborate a bit more on the logic here?
When is is_automerge true? When the automerge label is applied to the issue or when the backport PR was approved by a core-dev review? Or both?
And what's the difference between the participants of pr_number and original_pr_number?
IIUC now in case of failure you are pinging the participants of the backport pr -- does that (only?) include whoever merged the backport PR?
(cc @DanielNoord)
Contributor
Author
There was a problem hiding this comment.
I commented out this code because it's no longer covered by tests, i.e. now really only auto-merges should emit comments on PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #577