Merged
Conversation
ddfisher
force-pushed
the
update-typed-ast
branch
from
d8f09b2 to
8c23122
Compare
|
|
||
| try: | ||
| from typed_ast import ast35 | ||
| from typed_ast import ast3 # type: ignore |
Member
There was a problem hiding this comment.
I'm guessing the typeshed stubs for typed_ast need an update? I can work on that if you're not already doing it.
gvanrossum
reviewed
Feb 13, 2017
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Awesome! Just a process nit (we need to remember to update the stubs), and waiting for the failing test to be fixed. We also need to fix docs/source/python36.rst before releasing mypy 0.480.
|
|
||
|
|
||
| class ASTConverter(ast3.NodeTransformer): | ||
| class ASTConverter(ast3.NodeTransformer): # type: ignore |
Member
There was a problem hiding this comment.
Can you open a typeshed issue to upgrade the typed_ast stubs, and link this (and similer ignores later) to it?
Collaborator
Author
|
Typeshed PR here: python/typeshed#931 |
Member
|
Whee! I'll leave the typeshed sync and the removal of the ignores for a later PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version of typed-ast supports all Python 3.6 syntax features. This unblocks #2622. The new version of typed_ast also supports type comments on
async withandasync for, support for which will be added in a subsequent PR.