Show library path and where each package is loaded from#20
Merged
gaborcsardi merged 6 commits intomasterfrom Sep 24, 2018
Merged
Show library path and where each package is loaded from#20gaborcsardi merged 6 commits intomasterfrom
gaborcsardi merged 6 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 90.29% 90.86% +0.57%
==========================================
Files 8 8
Lines 206 230 +24
==========================================
+ Hits 186 209 +23
- Misses 20 21 +1
Continue to review full report at Codecov.
|
Member
Author
|
This is not bad, but ideally we would distinguish between loaded path and on disk path. |
And warn if the two are not the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9.