Fixing import issue - tenant IDs can be strings

[jamiehannaford]

Fixes #455

[ycombinator]

Could you update the docblock for the method to match this change, please?

[jamiehannaford]

Sure - will do this and tests sometime tomorrow

[jamiehannaford]

Fixed

[ycombinator]

Sorry, I should've been clearer. I meant the comment that goes "If an integer is passed in..."

[ycombinator]

Could you please add unit tests for setTenant with string and numeric tenant IDs to https://github.com/jamiehannaford/php-opencloud/blob/import-tenant-fix/tests/OpenCloud/Tests/OpenStackTest.php?

[jamiehannaford]

@ycombinator Looks like we already test string and numeric tenant IDs but the existing tests aren't really testing what we want it to test. If the argument does not match the conditional (which it was doing before), the value populates the Tenant object. If Base.php is given a scalar value, it treats it as a ID and does a GET on that resource to get more information - which is what was happening here.

Ideally, what we want to test is that strings and IDs do not execute this GET request. The only way we can efficiently do this is by mocking the exact form of communication the OpenCloud\OpenStack object has with its collaborators; i.e. make sure this client does not invoke a particular method with a particular string of arguments. We don't have this level of mocking right now, but it's definitely something to look into for v2.

[jamiehannaford]

@ycombinator and this!