Update Service.php - constant value a typo?#480
Merged
jamiehannaford merged 1 commit intorackspace:workingfrom Dec 2, 2014
ficus:patch-1
Merged
Update Service.php - constant value a typo?#480jamiehannaford merged 1 commit intorackspace:workingfrom ficus:patch-1
jamiehannaford merged 1 commit intorackspace:workingfrom
ficus:patch-1
Conversation
Is this a a typo? Intended to be used with \OpenCloud\ObjectStore\Service and other service constructors? Also ambiguity of 'urlType' as used with archiveType is a little confusing. Use of constants and better naming would make the ability to use service net (internal) endpoints more obvious.
Contributor
Author
|
Also seeing that the effect of 'publicUrl' is achieved passing null, not that string. |
jamiehannaford
pushed a commit
that referenced
this pull request
Dec 2, 2014
Update Service.php - constant value a typo?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this a a typo? Intended to be used with \OpenCloud\ObjectStore\Service and other service constructors? Also ambiguity of 'urlType' as used with archiveType is a little confusing. Use of constants and better naming would make the ability to use service net (internal) endpoints more obvious.