Inject Logger in service when available in Client#518
Merged
jamiehannaford merged 4 commits intorackspace:workingfrom Jan 7, 2015
Merged
Inject Logger in service when available in Client#518jamiehannaford merged 4 commits intorackspace:workingfrom
jamiehannaford merged 4 commits intorackspace:workingfrom
Conversation
* allow OpenStack Logger to be set via options array
Contributor
|
This is looking good. Would you mind adding a bit of documentation explaining the new OpenStack.php option? i.e. that it needs to implement LoggerInterface etc. |
added information about injecting `Logger` in the client
also add `Logger` injection to Clients userguide
Contributor
Author
|
@jamiehannaford I've added some info to the getting started guide, and added a link to the clients userguide. |
jamiehannaford
pushed a commit
that referenced
this pull request
Jan 7, 2015
Inject Logger in service when available in Client
Contributor
Author
|
👍 can you release 1.12.2 tag so I don't have to step off my composer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inject the
Loggerinto theServicewhen theClientalready has one.Also allow passing a PSR-3 Logger via the
$optionsarray in theOpenStackconstructor.Added tests to ensure that all services that can be created using the
OpenStackclass do support this.