Skip to content

Fix CDN container population when iterating#527

Merged
ycombinator merged 3 commits intorackspace:workingfrom
jamiehannaford:cdn-list-fix
Jan 15, 2015
Merged

Fix CDN container population when iterating#527
ycombinator merged 3 commits intorackspace:workingfrom
jamiehannaford:cdn-list-fix

Conversation

@jamiehannaford
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for refactoring this down. It was silly to have a base class with conditional logic depending on the type of the instance.

@ycombinator
Copy link
Copy Markdown
Contributor

I don't see any mention of CDNService in the ObjectStore documentation. How and when is a user supposed to instantiate this service?

@jamiehannaford
Copy link
Copy Markdown
Contributor Author

@ycombinator I don't think there is any 😞 I've just added a quick reference

@ycombinator
Copy link
Copy Markdown
Contributor

Thanks @jamiehannaford. I've also created #528 to port your quick reference into the user guide + create code sample(s).

ycombinator added a commit that referenced this pull request Jan 15, 2015
Fix CDN container population when iterating
@ycombinator ycombinator merged commit d31c08d into rackspace:working Jan 15, 2015
@jamiehannaford jamiehannaford deleted the cdn-list-fix branch January 15, 2015 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants