Return array of DataObjects if such is requested.#546
Merged
ycombinator merged 9 commits intorackspace:workingfrom Mar 2, 2015
Merged
Return array of DataObjects if such is requested.#546ycombinator merged 9 commits intorackspace:workingfrom
ycombinator merged 9 commits intorackspace:workingfrom
Conversation
Contributor
|
LGTM - not sure why Travis is taking so long... |
Contributor
Author
|
@jamiehannaford I've made all the changes per the code review. |
Contributor
|
@ycombinator feel free to self-merge this when travis passes 👍 |
Contributor
Author
|
Self-merging as Travis build has passed. |
ycombinator
added a commit
that referenced
this pull request
Mar 2, 2015
Return array of DataObjects if such is requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #545, I provided a workaround for what the user was requesting. This PR provides a more robust solution.
Fixes #545.
Attn: @jamiehannaford