Skip to content

Migrate docs to RST#549

Merged
ycombinator merged 32 commits intorackspace:workingfrom
jamiehannaford:rst-conversion
Mar 9, 2015
Merged

Migrate docs to RST#549
ycombinator merged 32 commits intorackspace:workingfrom
jamiehannaford:rst-conversion

Conversation

@jamiehannaford
Copy link
Copy Markdown
Contributor

@jamiehannaford jamiehannaford commented Mar 3, 2015

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 3, 2015

Coverage Status

Coverage remained the same at 88.25% when pulling fcdd78a on jamiehannaford:rst-conversion into eaeb0fc on rackspace:working.

@jamiehannaford
Copy link
Copy Markdown
Contributor Author

jamiehannaford commented Mar 6, 2015

@ycombinator This is ready for review when you get a moment :)

@jamiehannaford jamiehannaford changed the title [wip] Migrate docs to RST Migrate docs to RST Mar 6, 2015
ycombinator
ycombinator reviewed Mar 6, 2015
View reviewed changes
Comment thread doc/services/database/configurations.rst Outdated
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator Mar 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will these links work, given that the samples are (currently) in GitHub?

Copy link
Copy Markdown
Contributor Author

@jamiehannaford jamiehannaford Mar 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, we should probably incorporate the full URL like

https://github.com/rackspace/php-opencloud/blob/master/samples/Database/create-configuration.php

@jamiehannaford
Copy link
Copy Markdown
Contributor Author

jamiehannaford commented Mar 9, 2015

@ycombinator I've made changes based on your feedback and included Security Groups docs too

ycombinator
ycombinator reviewed Mar 9, 2015
View reviewed changes
Comment thread doc/services/networking/security-groups.rst Outdated
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator Mar 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a spot with linking to the absolute GitHub URL for the sample file.

ycombinator
ycombinator reviewed Mar 9, 2015
View reviewed changes
Comment thread doc/index.rst Outdated
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator Mar 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the links on this line and the next end with .html? Asking because the users link on https://github.com/rackspace/php-opencloud/pull/549/files#diff-00538670582db41d732b5d707262f15aR79 doesn't end with .html.

Copy link
Copy Markdown
Contributor Author

@jamiehannaford jamiehannaford Mar 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I think the correct thing to use is :doc: - I've just built it locally and it seems to cross-reference the other document fine

@ycombinator
Copy link
Copy Markdown
Contributor

ycombinator commented Mar 9, 2015

LGTM. Merging.

ycombinator added a commit that referenced this pull request Mar 9, 2015
@ycombinator
Merge pull request #549 from jamiehannaford/rst-conversion
6054358 
Migrate docs to RST
@ycombinator ycombinator merged commit 6054358 into rackspace:working Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamiehannaford @coveralls @ycombinator