Using custom cipher suite for Rackspace Cloud Databases service#562
Using custom cipher suite for Rackspace Cloud Databases service#562jamiehannaford merged 13 commits intorackspace:workingfrom
Conversation
There was a problem hiding this comment.
could we break up the text over multiple lines? (I think this is a PSR requirement) - we'll find out soon with the linter :)
There was a problem hiding this comment.
Will do. Fixing.
dcf3fa5 to
d4ff6f4
Compare
|
Alright @jamiehannaford this is ready for review again. |
There was a problem hiding this comment.
could we add donald's comment about what the string means as a docblock?
There was a problem hiding this comment.
Is it okay if I add a link to Donald's comment (https://github.com/rackspace/php-opencloud/issues/560#issuecomment-81790778) in the docblock? I'm referencing the GitHub issue in other docblocks + the critical log message as well. The advantage of this is that the conversation in the GitHub issue provides more context than we could include inline in the code.
There was a problem hiding this comment.
sure, that sounds good
|
apart from the docblock thing, LGTM 👍 |
Using custom cipher suite for Rackspace Cloud Databases service
See #560 (comment).
Fixes #560 (temporarily).