-
Notifications
You must be signed in to change notification settings - Fork 247
Added symlink functionality via X-Object-Manifest header management #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f0fbce0
Added symlink functionality via X-Object-Manifest header management
markchalloner 6ce77ce
Added createSymlinkFrom. Renamed symlink to createSymlinkTo. Made set…
markchalloner ceebd95
Added getManifest assertions to symlink tests
markchalloner a5cba84
Changed symlink failures from null to exceptions. Added tests.
markchalloner f3a5658
Added documentation
markchalloner 9958eb9
Updated phpdoc for createSymlink functions
markchalloner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
lib/OpenCloud/ObjectStore/Exception/ObjectNotEmptyException.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <?php | ||
| /** | ||
| * Copyright 2012-2014 Rackspace US, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| namespace OpenCloud\ObjectStore\Exception; | ||
|
|
||
| class ObjectNotEmptyException extends \RuntimeException | ||
| { | ||
| public static function factory($name) | ||
| { | ||
| $message = sprintf( | ||
| "%s could not be overwritten as it contains content.", | ||
| $name | ||
| ); | ||
|
|
||
| $e = new self($message); | ||
|
|
||
| $e->name = $name; | ||
|
|
||
| return $e; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| <?php | ||
| /** | ||
| * Copyright 2012-2014 Rackspace US, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| require dirname(__DIR__) . '/../vendor/autoload.php'; | ||
|
|
||
| use OpenCloud\Rackspace; | ||
|
|
||
| // 1. Instantiate a Rackspace client. You can replace {authUrl} with | ||
| // Rackspace::US_IDENTITY_ENDPOINT or similar | ||
| $client = new Rackspace('{authUrl}', array( | ||
| 'username' => '{username}', | ||
| 'apiKey' => '{apiKey}', | ||
| )); | ||
|
|
||
| // 2. Obtain an Object Store service object from the client. | ||
| $objectStoreService = $client->objectStoreService(null, '{region}'); | ||
|
|
||
| // 3. Get container. | ||
| $container = $objectStoreService->getContainer('{sourceContainerName}'); | ||
|
|
||
| // 4. Get object. | ||
| $object = $container->getObject('{objectName}'); | ||
|
|
||
| // 5. Create another container for object's copy. | ||
| $objectStoreService->createContainer('{destinationContainerName}'); | ||
|
|
||
| // 6. Symlink to object from another container object. {objectName} must either not exist or be an empty file. | ||
| $object->createSymlinkFrom('{destinationContainerName}/{objectName}'); | ||
|
|
||
| // 7. Symlink from object to another container object. $object must be an empty file. | ||
| $object->createSymlinkTo('{destinationContainerName}/{objectName}'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment above on throwing exceptions instead of returning null. If you use exceptions, you could refactor the code below this comment to use guard clauses (which tend to be more readable in my opinion) like so: