Fix temp public URL missing file path info#653
Merged
jamiehannaford merged 1 commit intorackspace:workingfrom Jan 20, 2016
Merged
Fix temp public URL missing file path info#653jamiehannaford merged 1 commit intorackspace:workingfrom
jamiehannaford merged 1 commit intorackspace:workingfrom
Conversation
Should fix rackspace#648 Using `combine` didn't work, as it would either override the path info, or when swapped it would override the external host info with the internal host.
jamiehannaford
pushed a commit
that referenced
this pull request
Jan 20, 2016
Fix temp public URL missing file path info
Contributor
|
👍 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #648
Using
combinedidn't work, as it would either override the path info, or would override the external host info with the internal host, depending on order of combine.