Fix: Detect and warn when schedules generate multiple CRONs#707
Merged
rosa merged 3 commits intorails:mainfrom Feb 18, 2026
Merged
Fix: Detect and warn when schedules generate multiple CRONs#707rosa merged 3 commits intorails:mainfrom
rosa merged 3 commits intorails:mainfrom
Conversation
Fixes rails#703 - Use Fugit::Nat.parse with multi: :fail to detect schedules that generate multiple CRONs - Raise validation error with clear message when multiple CRONs detected - Add tests for single CRON, multiple times (same/different minutes) - Prevents silent failures where only first CRON was used
rosa
reviewed
Feb 17, 2026
Member
rosa
left a comment
rosa
left a comment
There was a problem hiding this comment.
Sorry for the delay, and thanks for working on this 🙏🏻 This is a good idea! I'd like the changes to be a bit different, though, as it's a bit strange that parsed_schedule returns :multiple_crons_detected. Let me think about it.
Contributor
Author
Thanks for the feedback! I see your point about parsed_schedule returning :multiple — that does make the API a bit unintuitive. |
Member
|
I pushed some small tweaks and I think it looks better now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #703