Determining the availability of props.visible

[devdammit]

Hello Guys! I noticed that you check the props.visible by the presence of it in props.
Why not check for undefined?

tooltip/src/Tooltip.jsx

Line 72 in b5e43fd

if ('visible' in this.props) {

We use a rule eslint - react/require-default-props. And set props.visible as undefined in the defaultProps. And if the props.visible is equal to undefined, then he still gets to extraProps.popupVisible.

[benjycui]

But why, are you going to lint code in node_modules.

[devdammit]

@benjycui, No, of course, we do not check node_modules into the style code. :)
We have our UIkit, and we made a wrapper for rcTooltip. In this wrapper we describe props

[benjycui]

Why not check for undefined?

Yep, you can PR.

But I don't agree with this ESLint rule, we can set default prop for defaultXXX, but I don't think we should set default props for controlled props(e.g. value, visible..)

[oldwin]

@benjycui I agree with @mochachai, need to check it for undefined. For example in my case I need to use rc-tooltip in two different scenes inside the one component.

1. Will work like a standard tooltip
2. Will show preview with always opened tooltip

So I was going to just pass true or undefined in 'visible' props, but now I have to do one trick:

const props = {};
if (preview) {
  props.visible = true;
}

return (
  <Tooltip placement="bottom" {...props} />
)