Skip to content

Translate of react blog post react v15.6.2#200

Merged
jhonmike merged 3 commits intoreactjs:masterfrom
netochaves:translate-of-blog-post-react-v15.6.2
Apr 16, 2019
Merged

Translate of react blog post react v15.6.2#200
jhonmike merged 3 commits intoreactjs:masterfrom
netochaves:translate-of-blog-post-react-v15.6.2

Conversation

@netochaves
Copy link
Copy Markdown
Contributor

+1 #151

@netochaves netochaves mentioned this pull request Apr 10, 2019
45 tasks
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 10, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit cc5e0fd

https://deploy-preview-200--pt-br-reactjs.netlify.com

@netochaves
Copy link
Copy Markdown
Contributor Author

Eu fiz a PR antes de fazer a verificação com o yarn, my bad 😞.
Ao fazer a verificação deu o seguinte erro:

/home/dct/pt-BR.reactjs.org/src/templates/blog.js
  43:26  error  Syntax Error blog.js (18:33) Invalid character escape sequence: \d.

17:       fields {
18:         date(formatString: "DD \d\e MMMM \d\e YYYY", locale: "pt-br")
                                    ^
19:         path
  relay/graphql-syntax

✖ 1 problem (1 error, 0 warnings)

error Command failed with exit code 1.

Alguém tem idea do que pode ser?

@jhonmike jhonmike added blog Blog post translation needs review A pull request ready to be reviewed labels Apr 11, 2019
@jhonmike
Copy link
Copy Markdown
Member

acho q ao atualizar o branch o erro sumiu, ou ainda persiste?

@netochaves
Copy link
Copy Markdown
Contributor Author

acho q ao atualizar o branch o erro sumiu, ou ainda persiste?

Continua o erro, apesar de o netlify ter passado todos os testes. Eu atualizei a branch localmente mas nada, estranho o.o

@jhonmike
Copy link
Copy Markdown
Member

@netochaves rodei aqui o yarn, yarn dev, yarn build e não deu erro

@netochaves
Copy link
Copy Markdown
Contributor Author

netochaves commented Apr 11, 2019

@jhonmike rodou o yarn check-all?

@jhonmike
Copy link
Copy Markdown
Member

Oouu de fato esta dando erro :(, vou verificar aqui, pois, parece que este erro não é de agora!!

@netochaves
Copy link
Copy Markdown
Contributor Author

certo

@jhonmike
Copy link
Copy Markdown
Member

Andei pesquisando e não achei nada sobre essa validação do linter, mas pensaria em tentar a seguinte proposta:

date(formatString: "DD/MM/YYYY", locale: "pt-br")

acho q seria uma boa, mas se tu for fazer, acho legal abrir um novo PR com esse ajustes, explicando o problema que tivemos, se estiver sem tempo, eu abro mais tarde o PR

@netochaves
Copy link
Copy Markdown
Contributor Author

No momento estou sem tempo mas esse erro já estava acontecendo anteriormente? porque não alterei esse arquivo.

@jhonmike
Copy link
Copy Markdown
Member

Sim, aparentemente deixamos passar, por isso não se preocupe neste PR, vamos continuar o Code Review, mas podemos ajustar em um novo PR e discutir qual será a melhor solução!!

@netochaves
Copy link
Copy Markdown
Contributor Author

Ok, quando estiver com tempo posso dar uma estudada melhor no erro caso ele ainda não tenha sido resolvido.

Copy link
Copy Markdown
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apenas um pequeno ajuste 👏

Comment thread content/blog/2017-09-25-react-v15.6.2.md Outdated
@jhonmike jhonmike added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Apr 15, 2019
Co-Authored-By: netochaves <netobac1@gmail.com>
@netochaves netochaves changed the title translate of react blog post react v15.6.2 Translate of react blog post react v15.6.2 Apr 15, 2019
@netochaves
Copy link
Copy Markdown
Contributor Author

Obrigado pelas review @jhonmike

@jhonmike jhonmike added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Apr 16, 2019
@jhonmike jhonmike merged commit a397a57 into reactjs:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blog Blog post translation 🌐 translated Translation is completed for this page

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants