Skip to content

Context translation (ready)#164

Merged
another-guy merged 26 commits intoreactjs:masterfrom
egorzekov:context-translation
Mar 1, 2019
Merged

Context translation (ready)#164
another-guy merged 26 commits intoreactjs:masterfrom
egorzekov:context-translation

Conversation

@egorzekov
Copy link
Copy Markdown
Contributor

Коллеги, обратите внимание, что изменения в следующих файлах - результат того, что кто-то не запускал yarn check-all перед пул-реквестом:

modified:   gatsby-config.js
modified:   src/components/CodeEditor/CodeEditor.js
modified:   src/components/ErrorDecoder/ErrorDecoder.js
modified:   src/components/LayoutFooter/Footer.js
modified:   src/components/TitleAndMetaTags/TitleAndMetaTags.js
modified:   src/pages/index.js

@tesseralis tesseralis mentioned this pull request Feb 18, 2019
88 tasks
Copy link
Copy Markdown
Collaborator

@ntishkevich ntishkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lex111 @another-guy @gaearon
Также есть вопрос об использовании «...» в примерах вместо "..." ? Если стоит, то необходимо будет изменить тип кавычек в этом PRе

Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md Outdated
Comment thread content/docs/context.md
@lex111
Copy link
Copy Markdown
Member

lex111 commented Feb 18, 2019

@egorzekov отдельное спасибо за напоминание про команду, я сделал коммит сразу в мастер с исправлениями, чтобы в PR были только файлы, которые относятся к переводу.

@lex111
Copy link
Copy Markdown
Member

lex111 commented Feb 18, 2019

Подключил CI, теперь будем в курсе подобных ошибок 🤖

@lex111 lex111 added the needs review A pull request ready to be reviewed label Feb 18, 2019
Copy link
Copy Markdown
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Улучшения по коду.

Comment thread examples/context/motivation-problem.js Outdated
Comment thread examples/context/motivation-problem.js Outdated
Comment thread examples/context/motivation-problem.js Outdated
Comment thread examples/context/motivation-solution.js Outdated
Comment thread examples/context/updating-nested-context-app.js Outdated
Comment thread examples/context/updating-nested-context-theme-toggler-button.js Outdated
lex111 and others added 20 commits February 19, 2019 17:15
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 21, 2019

Deploy preview for ru-reactjs failed.

Built with commit 2286f2d

https://app.netlify.com/sites/ru-reactjs/deploys/5c79a51589adb7000a2dc2b2

Comment thread examples/context/multiple-contexts.js Outdated
Comment thread content/docs/context.md
@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Mar 1, 2019
@another-guy another-guy merged commit b16ec10 into reactjs:master Mar 1, 2019
@another-guy
Copy link
Copy Markdown
Collaborator

Спасибо за перевод и фиксы, @egorzekov ! 💯

@another-guy another-guy removed their assignment Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs proofread A read-through is still needed to release the document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants