Skip to content

fixes Connect All Relevant Features to config files#57

Merged
el-rabies merged 2 commits intoreactome:mainfrom
Srujithchaithanya1:feature/configFile
Apr 6, 2026
Merged

fixes Connect All Relevant Features to config files#57
el-rabies merged 2 commits intoreactome:mainfrom
Srujithchaithanya1:feature/configFile

Conversation

@Srujithchaithanya1
Copy link
Copy Markdown
Contributor

Fixes #15

@autofix-troubleshooter
Copy link
Copy Markdown

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@Srujithchaithanya1
Copy link
Copy Markdown
Contributor Author

Hi @adamjohnwright @jweiser @EliotRagueneau can anyone please review this PR. I have added the configuration (version info, base URLs, feature flags, API routes, and external links) into TS files, replacing dynamic JSON imports with static constants for better maintainability, while ensuring all components (StatsService, HomeHelp, NavigationBar, etc.) now use the unified APP_CONFIG and related modules

@el-rabies el-rabies self-requested a review April 6, 2026 18:25
@el-rabies
Copy link
Copy Markdown
Collaborator

Hi @adamjohnwright @jweiser @EliotRagueneau can anyone please review this PR. I have added the configuration (version info, base URLs, feature flags, API routes, and external links) into TS files, replacing dynamic JSON imports with static constants for better maintainability, while ensuring all components (StatsService, HomeHelp, NavigationBar, etc.) now use the unified APP_CONFIG and related modules

I will review.

Copy link
Copy Markdown
Collaborator

@el-rabies el-rabies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@el-rabies el-rabies merged commit 2cb2ffa into reactome:main Apr 6, 2026
1 check failed
@Srujithchaithanya1
Copy link
Copy Markdown
Contributor Author

Thanks @el-rabies

I could not tag you earlier. Is there any other medium of communication channel apart from this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connect All Relevant Features to config files

3 participants