Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds non-interactive / CI-friendly authentication and key handling to the CLI by supporting offline refresh tokens via environment variables, plus optional server-side session revocation on logout.
Changes:
- Extend OIDC discovery/config to include
end_session_endpointand add a revocation call onauth logout. - Add offline token flow:
retyc auth login --offlineprints a refresh token for CI, andRETYC_TOKENenables non-disk auth inGetValidToken. - Add
RETYC_KEY_PASSPHRASEto avoid interactive passphrase prompts and document CI/CD usage in the README.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/config/config.go | Adds EndSessionURL to OIDC config model. |
| internal/auth/oidc.go | Implements Revoke and supports RETYC_TOKEN env-based token refresh path. |
| internal/api/login.go | Parses and wires end_session_endpoint from OIDC discovery into config. |
| cmd/transfer.go | Centralizes key passphrase reading with RETYC_KEY_PASSPHRASE fallback to interactive prompt. |
| cmd/auth.go | Adds --offline login mode, logout revocation attempt, and offline-token detection helper. |
| README.md | Documents offline login and CI/CD environment variable usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f40ae04 to
564ca78
Compare
Contributor
Author
|
@copilot code review[agent] final review |
Contributor
Non-interactive / CI-friendly auth and key passphrase handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare non interactive usage (CI, scripts... etc).