Skip to content

Refacto code #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HanXHX merged 5 commits into from
Mar 12, 2026
Merged

Refacto code #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1037e74
:recycle: :art: Refacto transfer, drop some duplicate code
HanXHX Mar 12, 2026
d0d0062
:hammer: Do not check lint "errcheck" on print functions
HanXHX Mar 12, 2026
e8574eb
:memo: Force Claude to use lint
HanXHX Mar 12, 2026
6e227b6
:art: Use Cobra context in transfer commands
HanXHX Mar 12, 2026
9b08d61
:bug: Fix UTF-8 truncation in transfer file list
HanXHX Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ linters:
- misspell # detect commonly misspelled words
- nlreturn # check for missing return statements in functions
- whitespace # check for whitespace issues
settings:
errcheck:
exclude-functions:
- fmt.Fprint
- fmt.Fprintf
- fmt.Fprintln
Comment on lines +14 to +18
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linters.settings.errcheck.exclude-functions excludes all fmt.Fprint/Fprintf/Fprintln calls from errcheck across the entire codebase, which can hide real write errors (e.g., writing to files, network connections, or custom io.Writers). Prefer keeping errcheck enabled for fmt.* and either handle the returned error or add targeted //nolint:errcheck on the specific CLI-output calls where ignoring the error is intentional; alternatively, scope the exclusion to specific files/packages if golangci-lint v2 supports that.

Suggested change
errcheck:
exclude-functions:
- fmt.Fprint
- fmt.Fprintf
- fmt.Fprintln
errcheck: {}

Copilot uses AI. Check for mistakes.

issues:
fix: false # use `golangci-lint run --fix` to automatically fix some of the issues
1 change: 1 addition & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,3 +214,4 @@ The CLI exposes everything as `transfer`. Do not rename backend routes.
- `.retyc/` in CWD is gitignored (dev token/config should not be committed)
- `SilenceUsage: true` + `SilenceErrors: true` on rootCmd — errors printed once by `RunE`, not by cobra
- No auto-commit
- Always perform linting with `make lint-fix` after editing code (uses `golangci-lint` with `--fix` to auto-apply simple fixes)
1 change: 0 additions & 1 deletion cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
"github.com/spf13/viper"
)


var (
cfgFile string
debug bool
Expand Down
Loading
Loading