fix: prevent orphan transfers on key fetch and passphrase failures#9
Closed
Copilot wants to merge 2 commits intotransfer_with_recipientsfrom
Closed
fix: prevent orphan transfers on key fetch and passphrase failures#9Copilot wants to merge 2 commits intotransfer_with_recipientsfrom
Copilot wants to merge 2 commits intotransfer_with_recipientsfrom
Conversation
Co-authored-by: HanXHX <5664215+HanXHX@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for recipient email addresses in transfers
fix: prevent orphan transfers on key fetch and passphrase failures
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two failure paths in
transfer createcould leave an incomplete, inaccessible transfer on the server with no cleanup.Changes
Sequential key fetch before share creation:
GetActiveKeyis now called beforeCreateShare. The previous parallel goroutine pattern meant a share could be created on the server even if the key fetch subsequently failed, with no way to clean it up.Disable share on passphrase failure: After share creation, if reading the passphrase from the terminal fails or an empty passphrase is submitted non-interactively,
DisableTransferis now called before returning the error.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.