Closed
Conversation
aronatkins
reviewed
Jan 9, 2023
| pkgRecord$remote_host, | ||
| pkgRecord$remote_username, | ||
| pkgRecord$remote_repo, | ||
| sub("/", "%2F", pkgRecord$remote_repo), |
Contributor
There was a problem hiding this comment.
Thanks, @galachad
Note to @toph-allen --
Per https://docs.gitlab.com/ee/api/repositories.html#get-file-archive, the :id needs to be URL-encoded. We may want to use this opportunity to escape other characters, as well.
URLencode(pkgRecord$remote_repo, TRUE)Additionally, we should update NEWS.
Contributor
There was a problem hiding this comment.
Yeah, we should use URLencode here, I think.
I'm also going to check GitHub and Bitbucket to see if we should treat them similar.
We may also want to add this case to the gitlabArchiveUrl test.
Thanks for submitting this, @galachad! I may open a new branch on rstudio/packrat to make the above changes, and if I do that, I'll close this PR with a reference to that.
aronatkins
added a commit
that referenced
this pull request
Jan 9, 2023
Contributor
|
Replaced by #700. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another gitlab bug to fix cc: @aronatkins.
This change allow install packages from subgroups.
Example:
https://gitlab.com/main518/child/skeleton
Minimal reproduce example:
The
/needs to be replace with%2Ffor RemoteRepo.