Remove an unnecessary each call#72
Closed
nobu wants to merge 1 commit intoruby:masterfrom
Closed
Conversation
olleolleolle
approved these changes
Nov 25, 2025
Member
|
Will we drop 2.5 support? |
ioquatix
approved these changes
Dec 9, 2025
Member
|
There is no reason to change this just to use Ruby 2.6 or later. Dropping support for older Rubies should only happen when there are features or bug fixes that are only available in newer versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String#splityields each element if the block is given, since ruby 2.6.