chore: forward-port NEWS/changelog entries for clarity#114
Merged
k0kubun merged 1 commit intoruby:masterfrom Apr 22, 2026
Merged
chore: forward-port NEWS/changelog entries for clarity#114k0kubun merged 1 commit intoruby:masterfrom
k0kubun merged 1 commit intoruby:masterfrom
Conversation
k0kubun
approved these changes
Apr 22, 2026
Contributor
Author
|
@k0kubun thanks! so would you consider a backport release of 2.2.3.1 via v2.2.3...chadlwilson:erb:ruby-3.1 (or similar)? Or that's a "no", and you suggest JRuby upgrades its default gem for 3.1-compatible branch to 4.0.x? |
Member
|
Sorry, no, having four different branches is already too much overhead, so we can't maintain erb for EOL Ruby versions. |
Contributor
Author
|
OK, thank you for replying @k0kubun - that's reasonable. Will consider moving to |
chadlwilson
added a commit
to chadlwilson/jruby
that referenced
this pull request
Apr 22, 2026
2.2.3 is EOL from CRuby perspective, so they will not backport the security fix to a maintained gem (I [asked](ruby/erb#114 (comment))). This thus deviates from the CRuby 3.1 stdlib version and bumps to 4.0.4.1 (as bundled with Ruby 3.4.x, maintained at https://github.com/ruby/erb/tree/ruby-3.4). This still has Ruby 2.7 compatibility and the two relevant "breaking" changes seem innocuous: https://github.com/ruby/erb/blob/ruby-3.4/NEWS.md (Drop deprecated -S option from command / Bump `required-ruby_version` to Ruby 2.7+) Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates changelog entries from earlier ruby branches making it easier to see the entire history in one place.
As a side note, I see all the historical branches have been deleted. I understand that Ruby 3.1 is EOL from CRuby PoV, however JRuby
9.4targets Ruby3.1compatibility, and is just about to go soft EOL itself.It thus targets erb
2.2.3. Would you consider doing a one-off2.2.3.1release? v2.2.3...chadlwilson:erb:ruby-3.1 (tests pass locally on CRuby 3.1 and JRuby 9.4)Otherwise I suppose jruby can consider deviating stdlib verisons and bumping to
4.0.3.1or4.0.4.1(which is probably fine?)