Remove require in signal handler to avoid ThreadError#294
Merged
aycabta merged 1 commit intoruby:masterfrom Oct 3, 2021
Merged
Conversation
`rdoc` has been required so it looks unnecessary
Member
|
Thank you! |
pocke
deleted the
Remove__require__in_signal_handler_to_avoid_ThreadError
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a ThreadError, which is #282.
Fix #282
Problem
IRB does
require 'rdoc'inSHOW_DOC_DIALOGand it is called from a trap context. Then it causes the ThreadError.Solution
Remove the
requirefrom the proc. It looks unnecessary becauserdocis required from the top-level of the same file.irb/lib/irb/input-method.rb
Line 17 in 5f749c6