cipher: fix error checks for EVP_CIPHER_CTX_ctrl()#1041
Merged
rhenium merged 1 commit intoruby:masterfrom Apr 29, 2026
Merged
Conversation
The return value behaviour isn't explicitly documented for OpenSSL. For LibreSSL, it says [1]: > EVP_CIPHER_CTX_ctrl() returns 1 for success or 0 for failure. > Some implementations may return negative values for some errors. So it appears that we need to check for `<= 0` instead of `!0`. Furthermore, I looked for how OpenSSL does this and found it also does things inconsistently. I submitted a PR to check for `<= 0` which was accepted [2]. [1] https://man.openbsd.org/EVP_CIPHER_CTX_ctrl.3 [2] openssl/openssl#30923
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return value behaviour isn't explicitly documented for OpenSSL. For LibreSSL, it says [1]:
So it appears that we need to check for
<= 0instead of!0. Furthermore, I looked for how OpenSSL does this and found it also does things inconsistently. I submitted a PR to check for<= 0which was accepted [2].[1] https://man.openbsd.org/EVP_CIPHER_CTX_ctrl.3
[2] openssl/openssl#30923
This was found by a hybrid static-dynamic analyser that looks for inconsistent handling of error checks in bindings.